---
id: gh-requesting-code-review
name: "Requesting Code Review"
url: https://skills.yangsir.net/skill/gh-requesting-code-review
author: obra
domain: ai-code-generation-quality
tags: ["code-review", "quality-assurance", "ai-agent", "collaboration", "development-workflow"]
install_count: 520
rating: 4.20 (120 reviews)
github: https://github.com/obra/superpowers-skills/tree/main/skills/collaboration/requesting-code-review
---

# Requesting Code Review

> 此技能通过调度代码审查子代理，在开发流程中尽早对代码实现进行审查，确保其符合设计计划或需求。它能帮助开发者在问题扩大化之前发现并解决潜在缺陷，显著提升代码质量和开发效率，尤其适用于子代理驱动开发和复杂功能实现。

**Stats**: 520 installs · 4.2/5 (120 reviews)

## Before / After 对比

### 提升代码审查效率与质量

**Before**:

用户手动进行代码审查时，往往耗时较长，且容易受限于审查者的经验和精力，导致审查周期延长，关键问题被遗漏，增加了后期修复的成本和风险。

**After**:

该 Skill 能够通过智能子代理快速、一致地执行代码审查，在开发早期发现并指出潜在问题，大幅缩短审查周期，提高问题发现率，从而降低修复成本。

| Metric | Before | After | Change |
|---|---|---|---|
| 审查周期 | 240分钟 | 30分钟 | -87% |
| 关键问题遗漏率 | 20百分比 | 5百分比 | -75% |

## Readme

# Requesting Code Review

Dispatch code-reviewer subagent to catch issues before they cascade.

**Core principle:** Review early, review often.

## When to Request Review

**Mandatory:**
- After each task in subagent-driven development
- After completing major feature
- Before merge to main

**Optional but valuable:**
- When stuck (fresh perspective)
- Before refactoring (baseline check)
- After fixing complex bug

## How to Request

**1. Get git SHAs:**
```bash
BASE_SHA=$(git rev-parse HEAD~1)  # or origin/main
HEAD_SHA=$(git rev-parse HEAD)
```

**2. Dispatch code-reviewer subagent:**

Use Task tool with code-reviewer type, fill template at `code-reviewer.md`

**Placeholders:**
- `{WHAT_WAS_IMPLEMENTED}` - What you just built
- `{PLAN_OR_REQUIREMENTS}` - What it should do
- `{BASE_SHA}` - Starting commit
- `{HEAD_SHA}` - Ending commit
- `{DESCRIPTION}` - Brief summary

**3. Act on feedback:**
- Fix Critical issues immediately
- Fix Important issues before proceeding
- Note Minor issues for later
- Push back if reviewer is wrong (with reasoning)

## Example

```
[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | awk '{print $1}')
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch code-reviewer subagent]
  WHAT_WAS_IMPLEMENTED: Verification and repair functions for conversation index
  PLAN_OR_REQUIREMENTS: Task 2 from docs/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]
```

## Integration with Workflows

**Subagent-Driven Development:**
- Review after EACH task
- Catch issues before they compound
- Fix before moving to next task

**Executing Plans:**
- Review after each batch (3 tasks)
- Get feedback, apply, continue

**Ad-Hoc Development:**
- Review before merge
- Review when stuck

## Red Flags

**Never:**
- Skip review because "it's simple"
- Ignore Critical issues
- Proceed with unfixed Important issues
- Argue with valid technical feedback

**If reviewer wrong:**
- Push back with technical reasoning
- Show code/tests that prove it works
- Request clarification

See template at: skills/collaboration/requesting-code-review/code-reviewer.md


---
*Source: https://skills.yangsir.net/skill/gh-requesting-code-review*
*Markdown mirror: https://skills.yangsir.net/api/skill/gh-requesting-code-review/markdown*